Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the author copyright notices #5197

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Remove the author copyright notices #5197

merged 1 commit into from
Aug 23, 2023

Conversation

cakebaker
Copy link
Contributor

This PR removes the author copyright notices from files missed by #5184

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Aug 23, 2023 •
edited
Loading

Do you know why these were missed? Is the format slightly different? Maybe it's a good idea to completely standardize all the copyright notices?

@cakebaker
Copy link
Contributor Author

The format is slightly different, they all use * in the comments.

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Aug 23, 2023 •
edited
Loading

It all seems to be a bit messy. Here are the first four lines of all the files in src that are not main.rs (thanks nushell!). I'd propose that we convert all to variant 0.

╭────┬────────────────────────────────────────────────────────────────────────────────────╮
|  0 │ // This file is part of the uutils coreutils package.                              │
│    │ //                                                                                 │
│    │ // For the full copyright and license information, please view the LICENSE         │
│    │ // file that was distributed with this source code.                                │
│  1 │ // This file is part of the uutils coreutils package.                              │
│    │ //                                                                                 │
│    │ // For the full copyright and license information, please view the LICENSE file    │
│    │ // that was distributed with this source code.                                     │
│  2 │ //  * This file is part of the uutils coreutils package.                           │
│    │ //  *                                                                              │
│    │ //  * For the full copyright and license information, please view the LICENSE      │
│    │ //  * file that was distributed with this source code.                             │
│  3 │ // This file is part of the uutils coreutils package.                              │
│    │ //                                                                                 │
│    │ //  For the full copyright and license information, please view the LICENSE        │
│    │ // file that was distributed with this source code.                                │
│  4 │ #![allow(clippy::missing_safety_doc)]                                              │
│    │ #![allow(clippy::extra_unused_lifetimes)]                                          │
│    │                                                                                    │
│    │ // This file is part of the uutils coreutils package.                              │
│  5 │ // * This file is part of the uutils coreutils package.                            │
│    │ // *                                                                               │
│    │ // * For the full copyright and license information, please view the LICENSE file  │
│    │ // * that was distributed with this source code.                                   │
│  6 │ // This file is part of the uutils coreutils package.                              │
│    │ //                                                                                 │
│    │ //                                                                                 │
│    │ // For the full copyright and license information, please view the LICENSE         │
│  7 │ //* This file is part of the uutils coreutils package.                             │
│    │ //*                                                                                │
│    │ //* For the full copyright and license information, please view the LICENSE        │
│    │ //* file that was distributed with this source code.                               │
│  8 │ // spell-checker:ignore memmem                                                     │
│    │ //! Implementations of digest functions, like md5 and sha1.                        │
│    │ //!                                                                                │
│    │ //! The [`Digest`] trait represents the interface for providing inputs             │
│  9 │ //  * This file is part of the uutils coreutils package.                           │
│    │ //  *                                                                              │
│    │ //  * For the full copyright and license information, please view the LICENSE file │
│    │ //  * that was distributed with this source code.                                  │
│ 10 │ #![allow(unused_must_use)] // because we of writeln!                               │
│    │                                                                                    │
│    │ //  * This file is part of the uutils coreutils package.                           │
│    │ //  *                                                                              │
│ 11 │ // * This file is part of the uutils coreutils package.                            │
│    │ // *                                                                               │
│    │ // * For the full copyright and license information, please view the LICENSE       │
│    │ // * file that was distributed with this source code.                              │
│ 12 │ /*                                                                                 │
│    │  * This file is part of the uutils coreutils package.                              │
│    │  *                                                                                 │
│    │  * For the full copyright and license information, please view the LICENSE         │
│ 13 │ // TODO fix broken links                                                           │
│    │ #![allow(rustdoc::broken_intra_doc_links)]                                         │
│    │ //! Macros for the uucore utilities.                                               │
│    │ //!                                                                                │
╰────┴────────────────────────────────────────────────────────────────────────────────────╯

For reference, this is the nu command:

glob src/**/*.rs | filter { |it| not ($it | str ends-with "main.rs") } | each { |it| open --raw $it | lines | range 0..3 | str join "\n" } | uniq

@sylvestre sylvestre merged commit 3fc36ee into uutils:main Aug 23, 2023
@sylvestre
Copy link
Contributor

thanks

@cakebaker cakebaker deleted the remove_author_copyright_notices branch August 23, 2023 10:28
@tertsdiepraam tertsdiepraam mentioned this pull request Aug 24, 2023
Merged
cakebaker added a commit to cakebaker/coreutils that referenced this pull request Aug 25, 2023
@cakebaker
Remove the author copyright notices
b9c05ed 
from files missed by uutils#5184
and uutils#5197
@cakebaker cakebaker mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cakebaker @tertsdiepraam @sylvestre